Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

julia: fix mx.forward kwargs checking #16138

Merged
merged 1 commit into from
Sep 12, 2019
Merged

julia: fix mx.forward kwargs checking #16138

merged 1 commit into from
Sep 12, 2019

Conversation

iblislin
Copy link
Member

close dmlc/MXNet.jl#431

  • test case included

@iblislin iblislin merged commit d9364ba into master Sep 12, 2019
@iblislin iblislin deleted the ib/fix-forward branch September 12, 2019 13:42
iblislin added a commit that referenced this pull request Sep 12, 2019
@iblislin
julia: fix mx.forward kwargs checking (#16138)
6559b80 
close dmlc/MXNet.jl#431
@iblislin iblislin mentioned this pull request Sep 12, 2019
Merged
@Vikas-kum
Copy link
Contributor

@iblis17 the ci is failing on this PR. Please take a look at this - http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/master/1034/pipeline

And make sure that, CI passes and there is at least one review(just another pair of eyes looking at changes)

@iblislin
Copy link
Member Author

http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/master/1034/pipeline

hmm, I don't think it's related to this PR.

And make sure that, CI passes

yeah, it passed
https://github.com/apache/incubator-mxnet/pull/16138/commits

and there is at least one review(just another pair of eyes looking at changes)

Okay, I will wait for someone review it next time.

@Vikas-kum
Copy link
Contributor

No issues, thanks for checking. We will check if this is one off failure.
We are trying to make master stable, best effort. The CI test that runs on PR is just unit tests. There are several other test that runs when PR gets merged into master. So, CI can find regressions after getting merged into master and there we would require help from PR writers to investigate failures.

larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@iblislin @larroy
julia: fix mx.forward kwargs checking (apache#16138)
d807299 
close dmlc/MXNet.jl#431
iblislin added a commit that referenced this pull request Dec 17, 2019
@iblislin
backport Julia patches to v1.5.x (#16142)
3f449aa 
* julia: bump window prebult binary version to v1.5.0 (#15608)

- remove file REQUIRE, it's stale for Pkg3.jl

* update julia install doc (#15609)

* julia: fix `mx.forward` kwargs checking (#16138)

close dmlc/MXNet.jl#431

* Julia: add API docs back (#16348)

`ndarray` and `symbolic-node` have been refactored by splitting into a
few files in commits ed83071 and 36a3cb8, but the corresponding
document setting for MXNet.jl is not updated yet.

List all split source files into the `at_autodoc` setting.

Also refer to the `at_autodoc` setting in `julia/docs/src/api/optimizer.md`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Julia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

call mx.forward with kwargs occured an error.
2 participants
@iblislin @Vikas-kum